-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 use devflow to merge main into staging #2917
Conversation
2b09ef6
to
48ddccf
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
48ddccf
to
2e3e2ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 268 268
Lines 7592 7592
Branches 1692 1692
=======================================
Hits 7109 7109
Misses 483 483 ☔ View full report in Codecov by Sentry. |
printError(message) | ||
throw new Error(message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: No need to print the error here, the thrown error message will be displayed by runMain
) | ||
const jsonResponse = await rawResponse.json() | ||
|
||
printLog(jsonResponse) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: are you leaving this printLog for debug purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I wanted to remove it!
d7edd5f
to
92738b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
This reverts commit 6b867f7.
Motivation
Use devflow to merge
main
back intostaging-XX
.If this fails, it will create a fix PR and log something like this:
Changes
Testing
I have gone over the contributing documentation.