Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 [RUM-152] Add packages name modified next to commit in CHANGELOG #2889

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Jul 24, 2024

Motivation

We want the user to be able to identify changes per packages in the CHANGELOG

Changes

Added package names for each modification in the CHANGELOG

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault marked this pull request as ready for review July 24, 2024 00:32
@RomanGaignault RomanGaignault requested a review from a team as a code owner July 24, 2024 00:32
Copy link

cit-pr-commenter bot commented Jul 24, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.21 KiB 160.21 KiB 0 B 0.00%
Logs 56.82 KiB 56.82 KiB 0 B 0.00%
Rum Slim 108.78 KiB 108.78 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.002 0.000
addaction 0.030 0.039 0.008
adderror 0.032 0.033 0.001
addtiming 0.001 0.001 0.000
startview 0.900 0.905 0.005
startstopsessionreplayrecording 0.816 0.888 0.072
logmessage 0.018 0.023 0.004
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 21.45 KiB 21.08 KiB -378 B
addaction 71.97 KiB 71.73 KiB -247 B
adderror 87.07 KiB 89.07 KiB 2.00 KiB
addtiming 19.26 KiB 18.53 KiB -747 B
startview 347.99 KiB 352.76 KiB 4.77 KiB
startstopsessionreplayrecording 14.75 KiB 12.81 KiB -1987 B
logmessage 72.89 KiB 71.29 KiB -1639 B

🔗 RealWorld

@N-Boutaib N-Boutaib requested a review from a team July 24, 2024 07:58
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: this file is not a script, it should be moved in scripts/lib

@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Jul 25, 2024

🚂 Branch Integration: starting soon, median merge time is 12m

Commit b2607f6597 will soon be integrated into staging-30.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Jul 25, 2024
…ges-to-its-package (#2889) into staging-30

Integrated commit sha: b2607f6

Co-authored-by: roman.gaignault <[email protected]>
@dd-devflow
Copy link

dd-devflow bot commented Jul 25, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit b2607f6597 has been merged into staging-30 in merge commit c73f5eaf89.

Check out the triggered pipeline on Gitlab 🦊

@RomanGaignault RomanGaignault merged commit 44baa33 into main Jul 25, 2024
21 checks passed
@RomanGaignault RomanGaignault deleted the romanG/RUM-152-investigate-changelog-structure-to-link-changes-to-its-package branch July 25, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants