-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Remove classes in favour of functions #2885
Merged
N-Boutaib
merged 13 commits into
main
from
najib.boutaib/bundle-size-reduction-classes-removal
Jul 25, 2024
Merged
⚡️ Remove classes in favour of functions #2885
N-Boutaib
merged 13 commits into
main
from
najib.boutaib/bundle-size-reduction-classes-removal
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 266 266
Lines 7575 7564 -11
Branches 1685 1686 +1
=======================================
- Hits 7101 7091 -10
+ Misses 474 473 -1 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
RomanGaignault
approved these changes
Jul 24, 2024
BenoitZugmeyer
approved these changes
Jul 25, 2024
nulrich
approved these changes
Jul 25, 2024
N-Boutaib
deleted the
najib.boutaib/bundle-size-reduction-classes-removal
branch
July 25, 2024 10:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bundle size reduction.
Changes
Migrating some classes to functions.
Remaining classes:
AbstractLifeCylce
: Needs polymorphismObservable
: Failed to migrateWeakSet
: Polyfill of EI11 (will be cleaned eventually)Logger
: Prototype needed in codeTesting
I have gone over the contributing documentation.