Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUM-67] Specialise type files #2845

Merged
merged 21 commits into from
Jul 8, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Jul 4, 2024

Motivation

Specialise types files to have a more descriptive name.

Changes

Changed types name and import from different part of the SDK.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (5e97b4e) to head (73b0514).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2845      +/-   ##
==========================================
+ Coverage   93.34%   93.35%   +0.01%     
==========================================
  Files         263      263              
  Lines        7525     7525              
  Branches     1676     1676              
==========================================
+ Hits         7024     7025       +1     
+ Misses        501      500       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomanGaignault RomanGaignault changed the title specialise type files [RUM-67] Specialise type files Jul 4, 2024
@RomanGaignault RomanGaignault changed the title [RUM-67] Specialise type files ♻️ [RUM-67] Specialise type files Jul 4, 2024
@RomanGaignault RomanGaignault marked this pull request as ready for review July 4, 2024 09:55
@RomanGaignault RomanGaignault requested a review from a team as a code owner July 4, 2024 09:55
Copy link

cit-pr-commenter bot commented Jul 4, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.24 KiB 161.24 KiB 0 B 0.00%
Logs 57.96 KiB 57.96 KiB 0 B 0.00%
Rum Slim 109.18 KiB 109.18 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.001 -0.000
addaction 0.032 0.031 -0.001
adderror 0.031 0.030 -0.001
addtiming 0.001 0.001 0.000
startview 0.977 0.959 -0.017
startstopsessionreplayrecording 0.791 0.934 0.143
logmessage 0.019 0.024 0.005
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 19.32 KiB 20.83 KiB 1.51 KiB
addaction 69.04 KiB 70.75 KiB 1.71 KiB
adderror 85.08 KiB 85.38 KiB 301 B
addtiming 18.97 KiB 17.31 KiB -1704 B
startview 330.91 KiB 335.46 KiB 4.54 KiB
startstopsessionreplayrecording 13.34 KiB 14.02 KiB 700 B
logmessage 67.70 KiB 71.87 KiB 4.17 KiB

🔗 RealWorld

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion: sessionReplayPlayer.type.ts should be enough :)‏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion: browser.types.ts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♀️ Sorry, it was like this. I suggested the other way round.

@amortemousque
Copy link
Contributor

Nice!

@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Jul 8, 2024

🚂 Branch Integration: starting soon, median merge time is 11m

Commit 73b0514de7 will soon be integrated into staging-28.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Jul 8, 2024
@dd-devflow
Copy link

dd-devflow bot commented Jul 8, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 73b0514de7 has been merged into staging-28 in merge commit a97d0fecef.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-28 label Jul 8, 2024
@RomanGaignault RomanGaignault merged commit dc34ecd into main Jul 8, 2024
21 checks passed
@RomanGaignault RomanGaignault deleted the roman/RUM-67-specialise-type-files branch July 8, 2024 11:48
@RomanGaignault RomanGaignault changed the title ♻️ [RUM-67] Specialise type files ♻️ [RUM-67] Specialise type files Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants