-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUM-67] Specialise type files #2845
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2845 +/- ##
==========================================
+ Coverage 93.34% 93.35% +0.01%
==========================================
Files 263 263
Lines 7525 7525
Branches 1676 1676
==========================================
+ Hits 7024 7025 +1
+ Misses 501 500 -1 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
developer-extension/src/panel/sessionReplayPlayer/startSessionReplayPlayer.types.ts
Outdated
Show resolved
Hide resolved
developer-extension/src/panel/sessionReplayPlayer/startSessionReplayPlayer.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: sessionReplayPlayer.type.ts
should be enough :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: browser.types.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇♀️ Sorry, it was like this. I suggested the other way round.
Nice! |
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 11m Commit 73b0514de7 will soon be integrated into staging-28. Use |
Integrated commit sha: 73b0514 Co-authored-by: roman.gaignault <[email protected]>
🚂 Branch Integration: This commit was successfully integrated Commit 73b0514de7 has been merged into staging-28 in merge commit a97d0fecef. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
Specialise types files to have a more descriptive name.
Changes
Changed types name and import from different part of the SDK.
Testing
I have gone over the contributing documentation.