Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUM-5209] provide a span id for the initial document trace #2844

Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jul 3, 2024

Motivation

Without a span id, the backend does not create the RUM span

Changes

Generate a random span id for the RUM span.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner July 3, 2024 08:27
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Jul 3, 2024

🚂 Branch Integration: starting soon, median merge time is 11m

Commit 8b3ddf57bb will soon be integrated into staging-27.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Jul 3, 2024
…into staging-27

Integrated commit sha: 8b3ddf5

Co-authored-by: Benoît Zugmeyer <[email protected]>
@dd-devflow
Copy link

dd-devflow bot commented Jul 3, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 8b3ddf57bb has been merged into staging-27 in merge commit caa9ee9f00.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-27 label Jul 3, 2024
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.25 KiB 160.29 KiB 35 B +0.02%
Logs 57.91 KiB 57.91 KiB 0 B 0.00%
Rum Slim 108.77 KiB 108.81 KiB 35 B +0.03%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.035 0.049 0.014
adderror 0.037 0.046 0.010
addtiming 0.001 0.001 0.000
startview 1.018 4.507 3.488
startstopsessionreplayrecording 0.905 2.241 1.336
logmessage 0.021 0.040 0.019
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 19.82 KiB 19.62 KiB -204 B
addaction 68.05 KiB 69.99 KiB 1.94 KiB
adderror 84.86 KiB 84.14 KiB -727 B
addtiming 16.86 KiB 19.20 KiB 2.33 KiB
startview 313.29 KiB 321.31 KiB 8.02 KiB
startstopsessionreplayrecording 14.31 KiB 13.12 KiB -1211 B
logmessage 64.97 KiB 70.27 KiB 5.30 KiB

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer merged commit 73e3016 into main Jul 3, 2024
21 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/generate-span-id-for-initial-document-trace branch July 3, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants