-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Remove unnecessary session checks in collections #2769
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
- Coverage 93.58% 93.56% -0.02%
==========================================
Files 243 243
Lines 7048 7043 -5
Branches 1556 1555 -1
==========================================
- Hits 6596 6590 -6
- Misses 452 453 +1 ☔ View full report in Codecov by Sentry. |
750242c
to
697f6a9
Compare
/to-staging |
🚂 Branch Integration: starting soon, merge in < 33m Commit fabc81bb70 will soon be integrated into staging-22. This build is going to start soon! (estimated merge in less than 33m) Use |
Integrated commit sha: fabc81b Co-authored-by: Aymeric Mortemousque <[email protected]>
🚂 Branch Integration: This commit was successfully integrated Commit fabc81bb70 has been merged into staging-22 in merge commit c6e47584d3. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
We already check is the session is tracked in the assembly so we can remove unnecessary checks in resource and long task collections.
Changes
Testing
I have gone over the contributing documentation.