Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove unnecessary session checks in collections #2769

Merged
merged 2 commits into from
May 28, 2024

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented May 21, 2024

Motivation

We already check is the session is tracked in the assembly so we can remove unnecessary checks in resource and long task collections.

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner May 21, 2024 15:48
Copy link

cit-pr-commenter bot commented May 21, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 157.14 KiB 157.05 KiB -93 B -0.06%
Logs 56.26 KiB 56.26 KiB 0 B 0.00%
Rum Slim 103.69 KiB 103.59 KiB -93 B -0.09%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.002 0.000
addaction 0.015 0.020 0.004
adderror 0.042 0.050 0.008
addtiming 0.001 0.001 0.000
startview 0.871 1.259 0.388
startstopsessionreplayrecording 0.836 1.173 0.337
logmessage 0.005 0.005 0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫
addglobalcontext NaN KiB 24.83 KiB NaN KiB
addaction NaN KiB 50.11 KiB NaN KiB
adderror NaN KiB 49.81 KiB NaN KiB
addtiming NaN KiB 8.91 KiB NaN KiB
startview NaN KiB 2016.46 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 10.97 KiB NaN KiB
logmessage NaN KiB 62.41 KiB NaN KiB

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (36c2e80) to head (fabc81b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2769      +/-   ##
==========================================
- Coverage   93.58%   93.56%   -0.02%     
==========================================
  Files         243      243              
  Lines        7048     7043       -5     
  Branches     1556     1555       -1     
==========================================
- Hits         6596     6590       -6     
- Misses        452      453       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amortemousque amortemousque force-pushed the aymeric/remove-useless-session-check branch from 750242c to 697f6a9 Compare May 21, 2024 15:51
@amortemousque amortemousque changed the title 🔥 Remove unnecessary session check in collections 🔥 Remove unnecessary session checks in collections May 21, 2024
@amortemousque
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 27, 2024

🚂 Branch Integration: starting soon, merge in < 33m

Commit fabc81bb70 will soon be integrated into staging-22.

This build is going to start soon! (estimated merge in less than 33m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request May 27, 2024
@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 27, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit fabc81bb70 has been merged into staging-22 in merge commit c6e47584d3.

Check out the triggered pipeline on Gitlab 🦊

@amortemousque amortemousque merged commit bd1c3e7 into main May 28, 2024
21 checks passed
@amortemousque amortemousque deleted the aymeric/remove-useless-session-check branch May 28, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants