Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Cleanup experimental features #2768

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented May 21, 2024

Motivation

Cleanup experimental features:

Changes

Remove features/experimentations code and feature flags

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (146b4bf) to head (f56f2a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2768      +/-   ##
==========================================
+ Coverage   93.33%   93.56%   +0.23%     
==========================================
  Files         241      241              
  Lines        7077     7035      -42     
  Branches     1562     1548      -14     
==========================================
- Hits         6605     6582      -23     
+ Misses        472      453      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amortemousque amortemousque force-pushed the aymeric/cleanup-feature-flags branch from db80b9b to f56f2a5 Compare May 21, 2024 13:54
@amortemousque amortemousque marked this pull request as ready for review May 21, 2024 13:54
@amortemousque amortemousque requested a review from a team as a code owner May 21, 2024 13:54
@amortemousque amortemousque changed the title 🔥 Cleanup experimental code 🔥 Cleanup experimental features May 21, 2024
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 158.27 KiB 157.01 KiB -1291 B -0.80%
Logs 56.42 KiB 55.96 KiB -468 B -0.81%
Rum Slim 104.76 KiB 103.56 KiB -1232 B -1.15%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
adderror 0.031 0.038 0.007
addaction 0.015 0.019 0.004
logmessage 0.005 0.005 0.000
startview 0.841 0.843 0.002
startstopsessionreplayrecording 0.687 0.780 0.093
addtiming 0.001 0.001 0.000
addglobalcontext 0.001 0.002 0.000

@amortemousque
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented May 22, 2024

🚂 Branch Integration: starting soon, merge in < 10m

Commit f56f2a51fd will soon be integrated into staging-21.

This build is going to start soon! (estimated merge in less than 10m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request May 22, 2024
Integrated commit sha: f56f2a5

Co-authored-by: Aymeric Mortemousque <[email protected]>
@dd-devflow
Copy link

dd-devflow bot commented May 22, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit f56f2a51fd has been merged into staging-21 in merge commit f6cd16b182.

Check out the triggered pipeline on Gitlab 🦊

@amortemousque amortemousque merged commit 05769ac into main May 22, 2024
21 checks passed
@amortemousque amortemousque deleted the aymeric/cleanup-feature-flags branch May 22, 2024 13:56
thomas-lebeau added a commit that referenced this pull request May 23, 2024
… into staging-21

 pm_trace_id: 34920175
 feature_branch_pipeline_id: 34920175
 source: to-staging

* commit '2e832f631faaa273a4fe13f36d29fd8241df5eef':
  remove unused imports
  fix missing imports
  🔥 Cleanup experimental features (#2768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants