-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-4013] DD_RUM: add handling stack in beforeSend context #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
+ Coverage 93.58% 93.59% +0.01%
==========================================
Files 243 243
Lines 7043 7057 +14
Branches 1555 1563 +8
==========================================
+ Hits 6591 6605 +14
Misses 452 452 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
thomas-lebeau
force-pushed
the
thomas.lebeau/micro-frontend-rum
branch
from
April 30, 2024 13:04
73ea395
to
60046eb
Compare
thomas-lebeau
force-pushed
the
thomas.lebeau/micro-frontend-rum
branch
from
May 27, 2024 09:38
93301aa
to
8a3328f
Compare
BenoitZugmeyer
approved these changes
May 27, 2024
thomas-lebeau
changed the title
✨ [RUM-4013] add handling stack in beforeSend context
✨ [RUM-4013] DD_RUM: add handling stack in beforeSend context
May 28, 2024
nulrich
approved these changes
May 30, 2024
thomas-lebeau
added a commit
that referenced
this pull request
May 30, 2024
* ✨ [RUM-4013] add handling stack in beforeSend context * add handling stack for addErrors and addAction * 🧪 add e2e tests * add e2e and loose up unit tests * remove unused variable * 🧪 add missing test coverage * ✅ add e2e test for console errors * fix missing imports * remove unused imports * 👌 add type to e2e tests * 👌 fix pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Create a stack trace and expose it in the
beforeSend
'sdomainContext
argument.It allow customers to initialise the browser SDK with something like:
Changes
support the following APIs
DD_RUM.addError()
DD_RUM.addAction()
fetch()
resourcesxhr
resourcesTesting
I have gone over the contributing documentation.