-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-3684] Capture scroll record on shadow dom elements #2708
✨ [RUM-3684] Capture scroll record on shadow dom elements #2708
Conversation
Bundles Sizes Evolution
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for walking me through this!
.run(async ({ intakeRegistry }) => { | ||
const div = await getNodeInsideShadowDom('my-scrollable-div', 'button') | ||
|
||
await div.click() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: any reason to have a scroll triggered on click rather than scrolling directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, I just wanted to have a way to trigger the scroll once everything is setup (calling scrollTo
on the element from the test isn't working because the returned wdio.Element
doesn't allow this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the test itself trigger a scroll would be easier to follow but if it is not possible, adding a comment that clarify the intent could help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
==========================================
+ Coverage 93.34% 93.40% +0.05%
==========================================
Files 240 240
Lines 6986 6986
Branches 1540 1541 +1
==========================================
+ Hits 6521 6525 +4
+ Misses 465 461 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
Add support of scrolls inside of shadow dom elements for session replay.
Changes
Listen to scroll events on shadow roots
Testing
I have gone over the contributing documentation.