Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ use browser.execute and browser.executeAsync directly #2700

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

thomas-lebeau
Copy link
Collaborator

Motivation

Custom type definition where introduce to fix a bug in webdriverio. this bug is now fixed so there is no need to maintain our own custom types.

Moreover, the custom type was incomplete and I had to augment them in this PR

Changes

Use browser.execute and browser.executeAsync instead of our custom wrapper.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link

cit-pr-commenter bot commented Apr 8, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 157.53 KiB 157.53 KiB 0 B 0.00%
Logs 56.12 KiB 56.12 KiB 0 B 0.00%
Rum Slim 104.02 KiB 104.02 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
adderror 0.034 0.038 0.004
addaction 0.016 0.020 0.003
logmessage 0.007 0.006 -0.000
startview 1.087 0.966 -0.122
startstopsessionreplayrecording 0.756 0.941 0.185
addtiming 0.001 0.001 0.000
addglobalcontext 0.001 0.001 0.000

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/fix-browserExecute branch from 193d5ef to 078f31a Compare April 26, 2024 08:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (ea6ef66) to head (078f31a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
+ Coverage   93.25%   93.27%   +0.01%     
==========================================
  Files         240      240              
  Lines        7032     7032              
  Branches     1554     1554              
==========================================
+ Hits         6558     6559       +1     
+ Misses        474      473       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-lebeau thomas-lebeau marked this pull request as ready for review April 26, 2024 09:00
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner April 26, 2024 09:00
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🔥

@thomas-lebeau thomas-lebeau merged commit 1499092 into main Apr 26, 2024
19 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/fix-browserExecute branch April 26, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants