🐛 fix beforeSend type definition for logs #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-lebeau
force-pushed
the
thomas.lebeau/fix-beforesend-types
branch
from
13aba55 to
db9b257
Compare
Bundles Sizes Evolution
|
…le isolation compatibility
BenoitZugmeyer
approved these changes
Apr 4, 2024
|
/to-staging |
|
🚂 Branch Integration: this build is next, merge in < 10m Commit e9197c92f2 will soon be integrated into staging-14. This build is next! (estimated merge in less than 10m) Use |
dd-mergequeue bot
added a commit
that referenced
this pull request
Apr 4, 2024
…o staging-14 Co-authored-by: Thomas Lebeau <[email protected]>
|
🚂 Branch Integration: This commit was successfully integrated Commit e9197c92f2 has been merged into staging-14 in merge commit 69ced592ff. Check out the triggered pipeline on Gitlab 🦊 |
amortemousque
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fixes #2685
Changes
Add missing context argument to log's
beforeSendtype definitionTesting
I have gone over the contributing documentation.