-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUM-96] Ignore frustrations on clicks resulting in scrolls #2669
Merged
N-Boutaib
merged 8 commits into
main
from
najib.boutaib/RUM-96-ignore-frustrations-on-clicks-leading-to-scrolls
Mar 28, 2024
Merged
🐛 [RUM-96] Ignore frustrations on clicks resulting in scrolls #2669
N-Boutaib
merged 8 commits into
main
from
najib.boutaib/RUM-96-ignore-frustrations-on-clicks-leading-to-scrolls
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundles Sizes Evolution
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
==========================================
- Coverage 92.91% 92.88% -0.03%
==========================================
Files 239 239
Lines 6943 6947 +4
Branches 1519 1520 +1
==========================================
+ Hits 6451 6453 +2
- Misses 492 494 +2 ☔ View full report in Codecov by Sentry. |
N-Boutaib
force-pushed
the
najib.boutaib/RUM-96-ignore-frustrations-on-clicks-leading-to-scrolls
branch
from
March 25, 2024 13:15
98e2005
to
4a9e65d
Compare
N-Boutaib
force-pushed
the
najib.boutaib/RUM-96-ignore-frustrations-on-clicks-leading-to-scrolls
branch
from
March 26, 2024 15:17
71226c9
to
d9eb534
Compare
N-Boutaib
changed the title
[RUM-96] Ignore frustrations on clicks resulting in scrolls
🐛 [RUM-96] Ignore frustrations on clicks resulting in scrolls
Mar 27, 2024
thomas-lebeau
approved these changes
Mar 27, 2024
BenoitZugmeyer
approved these changes
Mar 27, 2024
N-Boutaib
deleted the
najib.boutaib/RUM-96-ignore-frustrations-on-clicks-leading-to-scrolls
branch
March 28, 2024 12:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, click on scrollbars, or more generally clicks resulting in page or element scrolling, are reported as
dead_clicks
orrage_clicks
(if more than three clicks occurred).This behaviour is misleading since those clicks did result in a change, which is the scrolling. Therefore, they shouldn't result in a frustration signal.
Changes
userActivity
scroll
user activity from being reported asdead_click
s andrage_click
sWarning
Clicks on scrollbar that do not result in a scroll event will still be reported as frustrations.
Testing
I have gone over the contributing documentation.