Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-3387] forward isAborted to beforeSend context #2665

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Mar 22, 2024

Motivation

Since we compute an isAborted property, we wanted to provide it as a beforeSend context attribute to allow customer to use it how they want, ex:

Changes

  • implement the concept of domain context for Logs' beforeSend method
  • forward isAborted so it's available in the beforeSend context for Logs and Rum

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@thomas-lebeau thomas-lebeau changed the title ✨ [RUM-3387] forward isborted to beforeSend context ✨ [RUM-3387] forward isAborted to beforeSend context Mar 25, 2024
@thomas-lebeau thomas-lebeau marked this pull request as ready for review March 25, 2024 09:30
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner March 25, 2024 09:30
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫% Status
Rum 156.09 kB 156.15 kB +0.04%
Logs 55.28 kB 55.34 kB +0.12%
Rum Slim 101.65 kB 101.72 kB +0.06%
Worker 25.21 kB 25.21 kB 0.00%

@thomas-lebeau
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Mar 25, 2024

⚠️ Branch Integration: staging-13 is not configured as an integration branch

We recommend you to add a file named staging.datadog.yml with the following content to register it:

schema-version: v1
kind: integration-branch
name: staging-13
team: <my-team-name>
update_automatically: true
update_at_most_every: 15m
reset_pattern: "0 12 * * Mon"
contacts:
- type: slack
  contact: <my-teams-ops-channel>
---

This configuration would keep your branch up-to-date with the base branch of this repository automatically and would get reset every Monday at noon UTC.

For more information: Integration Branches

If you need support, contact us on Slack #ci-interfaces!

@dd-devflow
Copy link

dd-devflow bot commented Mar 25, 2024

🚂 Branch Integration: starting soon, merge in < 9m

Commit b22357256e will soon be integrated into staging-13.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Mar 25, 2024
@dd-devflow
Copy link

dd-devflow bot commented Mar 25, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit b22357256e has been merged into staging-13 in merge commit 038202d138.

Check out the triggered pipeline on Gitlab 🦊

@thomas-lebeau thomas-lebeau merged commit 71cdd0c into main Mar 26, 2024
18 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/child-next-sibling branch March 26, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants