Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 configure renovate to deduplicate subdependencies #2643

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

This should fix the issue we have with every single "update all non-major dependencies" regarding @types/react ending with different versions and failing the build.

It will also make installing dependencies a bit faster since it won't have to download as many versions as before.

Changes

I chose the "highest" strategy (instead of "fewest"), because:

  • let's try to be as much up-to-date as possible
  • renovate will use the official yarn dedupe instead of a third party package

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

I chose the "highest" strategy (instead of "fewest"), because:
* let's try to be as much up-to-date as possible
* renovate will use the official `yarn dedupe` instead of a third party
  package
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner March 12, 2024 09:17
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫%
Rum 155.39 kB 155.39 kB 0.00%
Logs 54.83 kB 54.83 kB 0.00%
Rum Slim 100.98 kB 100.98 kB 0.00%
Worker 25.21 kB 25.21 kB 0.00%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (b3cc811) to head (e7e3653).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2643      +/-   ##
==========================================
+ Coverage   92.90%   92.91%   +0.01%     
==========================================
  Files         238      238              
  Lines        6919     6919              
  Branches     1514     1514              
==========================================
+ Hits         6428     6429       +1     
+ Misses        491      490       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenoitZugmeyer BenoitZugmeyer merged commit 9161f2b into main Mar 12, 2024
17 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/run-yarn-dedupe-with-renovate branch March 12, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants