🐛 [RUM-2445] fix unexpected session renewal after explicit session expiration #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 0s Commit 532f7bc242 will soon be integrated into staging-10. This build is going to start soon! (estimated merge in less than 0s) Use |
dd-mergequeue bot
added a commit
that referenced
this pull request
Mar 4, 2024
…h into staging-10 Co-authored-by: Benoît Zugmeyer <[email protected]>
|
🚂 Branch Integration: This commit was successfully integrated Commit 532f7bc242 has been merged into staging-10 in merge commit 3896374ffe. Check out the triggered pipeline on Gitlab 🦊 |
amortemousque
approved these changes
Mar 5, 2024
bcaudan
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When calling
stopSessionorsetTrackingConsent('not-granted'), the session should expire. But if for some reason the session expand/renewal was scheduled (ex: after some user interaction), a new session was created.Changes
Cancel any scheduled session expand/renewal when expiring the session.
Testing
I have gone over the contributing documentation.