Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️[RUM-2889] custom vitals improvements #2606

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 12, 2024

Motivation

Following #2591, add more features around custom vitals

Changes

  • 🐛 Fix multiple vital creation with multiple stop calls
  • ✨ Add event limiter for vitals
  • ✨ Add new API options:
DD_RUM.startDurationVital('foo', { context, startTime })
// do some stuff
DD_RUM.stopDurationVital('foo', { context, stopTime })

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner February 12, 2024 17:06
@bcaudan
Copy link
Contributor Author

bcaudan commented Feb 12, 2024

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 12, 2024

🚂 Branch Integration: starting soon, merge in < 9m

Commit 4c10701474 will soon be integrated into staging-07.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Feb 12, 2024
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 12, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 4c10701474 has been merged into staging-07 in merge commit 135905ab1e.

Check out the triggered pipeline on Gitlab 🦊

@bcaudan bcaudan merged commit f6d3465 into main Feb 15, 2024
18 checks passed
@bcaudan bcaudan deleted the bcaudan/custom-vitals-improvements branch February 15, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants