Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-308] do not track session without id #260

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 10, 2020

a tracked session must have a session id

a tracked session must have a session id
@bcaudan bcaudan requested a review from a team as a code owner February 10, 2020 16:56
@codecov-io
Copy link

Codecov Report

Merging #260 into master will increase coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #260      +/-   ##
========================================
+ Coverage   85.32%    86%   +0.68%     
========================================
  Files          24     24              
  Lines        1315   1315              
  Branches      277    277              
========================================
+ Hits         1122   1131       +9     
+ Misses        193    184       -9
Impacted Files Coverage Δ
packages/rum/src/rum.entry.ts 71.42% <0%> (+2.04%) ⬆️
packages/logs/src/loggerSession.ts 100% <0%> (+5.88%) ⬆️
packages/core/src/requestCollection.ts 96.15% <0%> (+13.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 627cd42...a2c81ae. Read the comment docs.

@bcaudan bcaudan merged commit edb1801 into master Feb 11, 2020
@bcaudan bcaudan deleted the bcaudan/stop-expired-session-tracking branch February 11, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants