⚡️ [RUM-2917] optimize getNodePrivacyLevel by adding a cache #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
changed the title
amortemousque
approved these changes
Jan 29, 2024
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 0s Commit f144a6f7a9 will soon be integrated into staging-05. This build is going to start soon! (estimated merge in less than 0s) Use |
dd-mergequeue bot
added a commit
that referenced
this pull request
Jan 29, 2024
… into staging-05 Co-authored-by: Benoît Zugmeyer <[email protected]>
|
🚂 Branch Integration: This commit was successfully integrated Commit f144a6f7a9 has been merged into staging-05 in merge commit cf710c7d9f. Check out the triggered pipeline on Gitlab 🦊 |
…ode-privacy-level
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
=======================================
Coverage 92.82% 92.83%
=======================================
Files 232 232
Lines 6760 6768 +8
Branches 1486 1489 +3
=======================================
+ Hits 6275 6283 +8
Misses 485 485 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A customer reported that
getNodePrivacyLevelwas a big performance bottleneck on their application when the devtools were open. On our side, we didn't observe a huge performance impact caused by this function (with or without devtools open), but still find a way to optimize it, which might help the customer case.Changes
Cache the node privacy level when processing mutations. The cache is local to the
proccessMutationsfunction so we don't have to implement a complex way to invalidate it. Even with this simple cache, we observed a nice speedup while processing mutations (from ~10ms to ~1.5ms in a specific case on the Datadog App)Testing
I have gone over the contributing documentation.