Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUM-2940] fix normalize URL for relative paths #2576

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 19, 2024

Motivation

Relative URLs are wrongly “normalized”, and those incorrect URL are used:

  • to define the @resource.url in Resource events, giving a wrong information to customers
  • to match the corresponding PerformanceTiming, so the SDK fails to find the corresponding timing, so the Resource event lacks detailed timings and size

Changes

Fix normalizeUrl and remove some unused functions

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bef13a) 92.85% compared to head (bb09e07) 92.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2576      +/-   ##
==========================================
+ Coverage   92.85%   92.87%   +0.01%     
==========================================
  Files         232      232              
  Lines        6761     6748      -13     
  Branches     1487     1486       -1     
==========================================
- Hits         6278     6267      -11     
+ Misses        483      481       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/fix-normalize-url branch 4 times, most recently from 302df4c to bb09e07 Compare January 22, 2024 13:03
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/fix-normalize-url branch from bb09e07 to 0d49ee5 Compare January 23, 2024 11:21
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Jan 23, 2024

🚂 Branch Integration: starting soon, merge in < 8m

Commit 0d49ee530c will soon be integrated into staging-04.

This build is going to start soon! (estimated merge in less than 8m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Jan 23, 2024
@dd-devflow
Copy link

dd-devflow bot commented Jan 23, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 0d49ee530c has been merged into staging-04 in merge commit 59f934893d.

Check out the triggered pipeline on Gitlab 🦊

@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review January 23, 2024 11:49
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner January 23, 2024 11:49
@BenoitZugmeyer BenoitZugmeyer merged commit d0ec8bd into main Jan 24, 2024
18 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-normalize-url branch January 24, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants