-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛[RUM-2752] Replay: generate censored images with custom dimensions #2565
Conversation
fae7cfd
to
2c06b39
Compare
/to-staging |
🚂 Branch Integration: starting soon, merge in < 7m Commit 2c06b39d6c will soon be integrated into staging-02. This build is going to start soon! (estimated merge in less than 7m) you can cancel this operation by commenting your pull request with |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
==========================================
- Coverage 92.85% 92.84% -0.01%
==========================================
Files 228 228
Lines 6746 6755 +9
Branches 1481 1483 +2
==========================================
+ Hits 6264 6272 +8
- Misses 482 483 +1 ☔ View full report in Codecov by Sentry. |
…o staging-02 Co-authored-by: Bastien Caudan <[email protected]>
🚂 Branch Integration: This commit was successfully integrated Commit 2c06b39d6c has been merged into staging-02 in merge commit f99088914d. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
Default censored image dimension is 1x1 which can cause rendering issue when the image size ratio is used by the browser to display the image.
Changes
Generate a censored image from the natural dimensions of the image, fallback to rendered dimension if not avialable.
Testing
I have gone over the contributing documentation.