Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUM-2752] Replay: generate censored images with custom dimensions #2565

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jan 11, 2024

Motivation

Default censored image dimension is 1x1 which can cause rendering issue when the image size ratio is used by the browser to display the image.

Screenshot 2024-01-11 at 18 08 34

Changes

Generate a censored image from the natural dimensions of the image, fallback to rendered dimension if not avialable.

Screenshot 2024-01-11 at 18 10 04

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan force-pushed the bcaudan/fix-replay-censoored-image branch from fae7cfd to 2c06b39 Compare January 12, 2024 09:16
@bcaudan bcaudan marked this pull request as ready for review January 12, 2024 09:18
@bcaudan bcaudan requested review from a team as code owners January 12, 2024 09:18
@bcaudan
Copy link
Contributor Author

bcaudan commented Jan 12, 2024

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Jan 12, 2024

🚂 Branch Integration: starting soon, merge in < 7m

Commit 2c06b39d6c will soon be integrated into staging-02.

This build is going to start soon! (estimated merge in less than 7m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (43c4456) 92.85% compared to head (eac1e95) 92.84%.
Report is 4 commits behind head on main.

Files Patch % Lines
.../domain/record/serialization/serializeAttribute.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2565      +/-   ##
==========================================
- Coverage   92.85%   92.84%   -0.01%     
==========================================
  Files         228      228              
  Lines        6746     6755       +9     
  Branches     1481     1483       +2     
==========================================
+ Hits         6264     6272       +8     
- Misses        482      483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dd-mergequeue bot added a commit that referenced this pull request Jan 12, 2024
@dd-devflow
Copy link

dd-devflow bot commented Jan 12, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 2c06b39d6c has been merged into staging-02 in merge commit f99088914d.

Check out the triggered pipeline on Gitlab 🦊

@bcaudan bcaudan merged commit 152e358 into main Jan 16, 2024
17 checks passed
@bcaudan bcaudan deleted the bcaudan/fix-replay-censoored-image branch January 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants