✨ Developer Extension improvements #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression from Mantine 7 upgrade
I believe this issue comes from the Mantine 7 upgrade, where Menu components are now using a Portal.
Do not clear events when an unrelated page is refreshed
BenoitZugmeyer
force-pushed
the
benoit/devext-enhancements
branch
from
076087b to
cadfefe
Compare
anediaz
reviewed
Nov 29, 2023
developer-extension/src/panel/components/tabs/eventsTab/eventsList.module.css
Outdated
Show resolved
Hide resolved
| @@ -1,3 +1,10 @@ | |||
| :root { | |||
| /* To keep z-index management simple, define all z-index values here, in ascending order */ | |||
|
🐛 Event list scrolled shadow is kept when the list is filtered and there is no scroll anymore
|
bcaudan
reviewed
Dec 1, 2023
BenoitZugmeyer
force-pushed
the
benoit/devext-enhancements
branch
from
897f41a to
ab7a226
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2516 +/- ##
==========================================
- Coverage 93.23% 93.12% -0.12%
==========================================
Files 222 224 +2
Lines 6655 6688 +33
Branches 1459 1465 +6
==========================================
+ Hits 6205 6228 +23
- Misses 450 460 +10 ☔ View full report in Codecov by Sentry. |
BenoitZugmeyer
force-pushed
the
benoit/devext-enhancements
branch
2 times, most recently
from
fcd550e to
3e4817c
Compare
BenoitZugmeyer
force-pushed
the
benoit/devext-enhancements
branch
from
3e4817c to
7eb1dee
Compare
Issue reported to Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1507025 |
anediaz
reviewed
Dec 4, 2023
| @@ -0,0 +1,122 @@ | |||
| import type { TelemetryEvent } from '../../../../../../packages/core/src/domain/telemetry' | |||
anediaz
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Bug fixes
Testing
I have gone over the contributing documentation.