🐛 [RUMF-71] prevent negative performance timing duration #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/fix-negative-durations
branch
from
50bf9c2 to
15838e3
Compare
BenoitZugmeyer
force-pushed
the
benoit/fix-negative-durations
branch
from
15838e3 to
b739cbc
Compare
bcaudan
reviewed
Feb 5, 2020
| if (start <= 0) { | ||
| return undefined | ||
| } | ||
| return { duration: msToNs(Math.max(end - start, 0)), start: msToNs(start) } |
There was a problem hiding this comment.
I am not so sure about doing this fix right now.
I would be in favor collecting info to understand better the issue and then discuss with the product what is the best way to handle it. We could prefer to not send the timing instead of setting the duration to 0.
There was a problem hiding this comment.
Ok, I opened #251 for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent negative performance timing by liming it to 0. Also filter out timings with invalid start values ('redirect' and 'ssl' generalization).