Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUM-1039] Harmonize view tests #2430

Merged
merged 11 commits into from
Sep 20, 2023
Merged

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Sep 15, 2023

Motivation

Following the view metrics splitting, this PR reorganize the view tracking tests so that every spec files tests its related module.

Changes

  • Cleanly stop INP tests
  • Move CLS support check in trackCommonViewMetrics module
  • Scope trackCumulativeLayoutShift tests
  • Scope trackLoadingTime tests
  • Scope trackViewEventCounts tests
  • Reorganize trackViews tests

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque marked this pull request as ready for review September 15, 2023 15:26
@amortemousque amortemousque requested a review from a team as a code owner September 15, 2023 15:26
@BenoitZugmeyer BenoitZugmeyer self-requested a review September 19, 2023 14:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #2430 (271831d) into main (5b6bb0b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2430      +/-   ##
==========================================
- Coverage   93.39%   93.33%   -0.07%     
==========================================
  Files         226      226              
  Lines        6644     6644              
  Branches     1479     1479              
==========================================
- Hits         6205     6201       -4     
- Misses        439      443       +4     
Files Changed Coverage Δ
.../domain/view/viewMetrics/trackCommonViewMetrics.ts 95.45% <100.00%> (-0.55%) ⬇️
...ain/view/viewMetrics/trackCumulativeLayoutShift.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque amortemousque merged commit b45d271 into main Sep 20, 2023
@amortemousque amortemousque deleted the aymeric/harmonize-view-tests branch September 20, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants