🐛 fix INP support detection #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Firefox 88, `PerformanceObserver.supportedEntryTypes` includes `'event'`, but `PerformanceEventTiming` is not implemented.
bcaudan
approved these changes
Sep 1, 2023
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 7m commit 8fd5137d59 will soon be integrated into staging-35. This build is going to start soon! (estimated merge in less than 7m) you can cancel this operation by commenting your pull request with |
|
🚂 Branch Integration: this commit was successfully integrated Commit 8fd5137d59 has been merged into staging-35 in merge commit e6f46de243. Check out the triggered pipeline on Gitlab 🦊 |
amortemousque
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On Firefox 88,
PerformanceObserver.supportedEntryTypesincludes'event', butPerformanceEventTimingis not implemented.Changes
Test in
PerformanceEventTimingexists before using it.Testing
I have gone over the contributing documentation.