✨ [extension] revamp event description and JSON viz #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
4 tasks
BenoitZugmeyer
changed the title
BenoitZugmeyer
force-pushed
the
benoit/extension--enhance-json-visualization
branch
from
d082dc8 to
cd350a9
Compare
BenoitZugmeyer
force-pushed
the
benoit/extension--revamp-filter-ui
branch
from
bc9d504 to
42d9c58
Compare
BenoitZugmeyer
force-pushed
the
benoit/extension--enhance-json-visualization
branch
from
cd350a9 to
16093c9
Compare
BenoitZugmeyer
force-pushed
the
benoit/extension--revamp-filter-ui
branch
from
42d9c58 to
a69b272
Compare
BenoitZugmeyer
force-pushed
the
benoit/extension--enhance-json-visualization
branch
from
16093c9 to
745b6df
Compare
BenoitZugmeyer
force-pushed
the
benoit/extension--revamp-filter-ui
branch
from
a69b272 to
5c375a9
Compare
BenoitZugmeyer
force-pushed
the
benoit/extension--enhance-json-visualization
branch
from
745b6df to
d784748
Compare
| ref as any | ||
| } | ||
| {...boxProps} | ||
| component={doesValueHasChildren(value) ? 'div' : 'span'} |
There was a problem hiding this comment.
❓ question: Why is this necessary?
There was a problem hiding this comment.
The value is displayed inline if it does not have children, ex:
WDYT? Is it overkill?
bcaudan
reviewed
Aug 25, 2023
developer-extension/src/panel/components/tabs/eventsTab/eventRow.tsx
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
force-pushed
the
benoit/extension--revamp-filter-ui
branch
2 times, most recently
from
d5fb319 to
6cdfaf1
Compare
BenoitZugmeyer
force-pushed
the
benoit/extension--enhance-json-visualization
branch
from
d784748 to
e3e5fbb
Compare
|
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
BenoitZugmeyer
force-pushed
the
benoit/extension--enhance-json-visualization
branch
from
e3e5fbb to
31cf3e8
Compare
bcaudan
approved these changes
Sep 14, 2023
amortemousque
approved these changes
Sep 14, 2023
BenoitZugmeyer
force-pushed
the
benoit/extension--revamp-filter-ui
branch
from
6e101fb to
5e870f2
Compare
BenoitZugmeyer
force-pushed
the
benoit/extension--enhance-json-visualization
branch
from
31cf3e8 to
64e6b66
Compare
BenoitZugmeyer
deleted the
benoit/extension--enhance-json-visualization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current JSON rendering component that we use does not allow to display a proper event description. Also it is a bit limited for future extensions.
Changes
Implement a new Json component and a better event description similar to the Datadog app
Before
After
Testing
I have gone over the contributing documentation.