Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Ignore workspace dependencies in check-release #2360

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Jul 27, 2023

Motivation

Since #2337, browser logs and rum have been added as workspace dependencies which makes check-release fail.

Changes

Ignore workspace dependencies in check-release

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner July 27, 2023 14:43
@amortemousque amortemousque merged commit 474a225 into main Jul 27, 2023
@amortemousque amortemousque deleted the aymeric/fix-check-release branch July 27, 2023 14:49
dhenkel92 pushed a commit to corona-school/browser-sdk that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants