🐛 [RUMF-1613] fix session replay performance regression #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help readability
BenoitZugmeyer
force-pushed
the
benoit/fix-session-replay-performance-regression
branch
from
afe06d1 to
4f57e1f
Compare
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 0s commit 4f57e1fef3 will soon be integrated into staging-26. This build is going to start soon! (estimated merge in less than 0s) you can cancel this operation by commenting your pull request with |
|
🚂 Branch Integration: this commit was successfully integrated commit 4f57e1fef3 has been merged into staging-26 in merge commit 83bb9ab641 |
amortemousque
approved these changes
Jun 29, 2023
bcaudan
approved these changes
Jun 29, 2023
BenoitZugmeyer
deleted the
benoit/fix-session-replay-performance-regression
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following the release of Shadow DOM support for Session Replay (#1969), users started to notice important performance regression on applications using session replay.
The identified issue was that we instrumented input Node property setters like
input.valueorinput.checkedmultiple times (once per Shadow Root). Those instrumentations are stacking up, making a significant overhead when the application set those properties.Changes
Do not instrument setters when handling shadow roots.
Before:
After:
Testing
I have gone over the contributing documentation.