♻️ Base foreground computation on page lifecycle states #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
commented
May 17, 2023
| }) | ||
| }) | ||
|
|
||
| it('should not record anything after reaching the maximum number of focus periods', () => { |
There was a problem hiding this comment.
I've removed this test that is now covered by the ValueHistory used in pageStateHistory.ts
bcaudan
reviewed
May 17, 2023
packages/rum-core/src/domain/rumEventsCollection/action/actionCollection.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2253 +/- ##
==========================================
- Coverage 94.23% 94.16% -0.08%
==========================================
Files 206 206
Lines 6180 6118 -62
Branches 1368 1354 -14
==========================================
- Hits 5824 5761 -63
- Misses 356 357 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
reviewed
May 22, 2023
Comment on lines
+98
to
+102
| view: { in_foreground: pageStateHistory.isInActivePageStateAt(action.startClocks.relative) }, | ||
| }, | ||
| autoActionProperties | ||
| ) | ||
| const inForeground = foregroundContexts.isInForegroundAt(action.startClocks.relative) | ||
| if (inForeground !== undefined) { | ||
| actionEvent.view = { in_foreground: inForeground } | ||
| } | ||
|
|
There was a problem hiding this comment.
💬 suggestion: what about keeping the same logic of not adding the view.in_foreground if there is no active page state?
There was a problem hiding this comment.
The previous foregroundContexts.isInForegroundAt(action.startClocks.relative) always return a boolean so inForeground !== undefined is always true
bcaudan
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up of #2229: Base foreground computation on page lifecycle states
Changes
pageStateHistory.isActiveAt()to replaceforegroundContexts.isInForegroundAt()pageStateHistory(implementmapToForegroundPeriods())Testing
I have gone over the contributing documentation.