Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [devext] add a live replay tab #2247

Merged
merged 4 commits into from
May 16, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented May 15, 2023

Motivation

Help Browser SDK users to tweak the integration by having a preview of how their website looks like via session replay.
Help Browser SDK developers investigate session replay rendering issues

Changes

Screenshot 2023-05-15 at 17 55 37

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

For the Replay tab, we don't want any margin, so this commit moves the
margin from the base Tabs to the Columns component used by the other
tabs.
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner May 15, 2023 15:56
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/developer-extension--session-replay-tab branch from fa15fc9 to 0223ff1 Compare May 15, 2023 15:56
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #2247 (f3badd4) into main (d93e0c1) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
+ Coverage   93.95%   94.09%   +0.14%     
==========================================
  Files         201      201              
  Lines        6083     6083              
  Branches     1347     1347              
==========================================
+ Hits         5715     5724       +9     
+ Misses        368      359       -9     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

@mbeaudru mbeaudru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: you had to duplicate & reproduce many things we already do in web-ui for our own sandbox - which is fine considering the scope of the project

But given the new frontend-framework "packages" strategy, I think we could at some point mutualise the two in a dedicated package to make such experiences simpler =). We recently had the case for S8S that wanted to digest records server-side in nodeJS


Nice job! As you already know, I see even more value than helping the SDK team debug things with this feature:

  • It could make the integration experience with replay a lot better for some customers, by allowing them to see if they have properly integrated replay SDK in their app and if they are comfortable with the level of privacy of the data that is about to be sent, before it is sent.
  • For replay team, it will be useful to troubleshoot & investigate issues on the renderer. It's pretty nice to be able to make a page that reproduce the problem, then open extension & debug with live-reload - instead of having to wait for ingestion, find your session, open replay page...

Just sharing my thoughts though 👍

Copy link
Member Author

BenoitZugmeyer commented May 16, 2023

@BenoitZugmeyer BenoitZugmeyer merged commit 0a0e00a into main May 16, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/developer-extension--session-replay-tab branch May 16, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants