-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [devext] add a live replay tab #2247
✨ [devext] add a live replay tab #2247
Conversation
For the Replay tab, we don't want any margin, so this commit moves the margin from the base Tabs to the Columns component used by the other tabs.
fa15fc9
to
0223ff1
Compare
Codecov Report
@@ Coverage Diff @@
## main #2247 +/- ##
==========================================
+ Coverage 93.95% 94.09% +0.14%
==========================================
Files 201 201
Lines 6083 6083
Branches 1347 1347
==========================================
+ Hits 5715 5724 +9
+ Misses 368 359 -9 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
developer-extension/src/panel/sessionReplayPlayer/startSessionReplayPlayer.ts
Outdated
Show resolved
Hide resolved
developer-extension/src/panel/sessionReplayPlayer/startSessionReplayPlayer.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: you had to duplicate & reproduce many things we already do in web-ui for our own sandbox - which is fine considering the scope of the project
But given the new frontend-framework "packages" strategy, I think we could at some point mutualise the two in a dedicated package to make such experiences simpler =). We recently had the case for S8S that wanted to digest records server-side in nodeJS
Nice job! As you already know, I see even more value than helping the SDK team debug things with this feature:
- It could make the integration experience with replay a lot better for some customers, by allowing them to see if they have properly integrated replay SDK in their app and if they are comfortable with the level of privacy of the data that is about to be sent, before it is sent.
- For replay team, it will be useful to troubleshoot & investigate issues on the renderer. It's pretty nice to be able to make a page that reproduce the problem, then open extension & debug with live-reload - instead of having to wait for ingestion, find your session, open replay page...
Just sharing my thoughts though 👍
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Motivation
Help Browser SDK users to tweak the integration by having a preview of how their website looks like via session replay.
Help Browser SDK developers investigate session replay rendering issues
Changes
Testing
I have gone over the contributing documentation.