🐛 [Extension] Fix TypeError when document.cookie is empty #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2216 +/- ##
==========================================
- Coverage 93.81% 93.80% -0.02%
==========================================
Files 201 201
Lines 6082 6082
Branches 1347 1347
==========================================
- Hits 5706 5705 -1
- Misses 376 377 +1 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenoitZugmeyer
approved these changes
May 9, 2023
bcaudan
approved these changes
May 12, 2023
yannickadam
deleted the
yannick.adam/fix_extension_cannot_read_property_of_null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Navigating to a site with no cookies and opening the developer panel leads to the extension erroring:
Datadog Browser SDK extension: [useSdkInfos] Error while getting SDK infos: Error: Failed to evaluate code: TypeError: Cannot read properties of null (reading 'slice')Changes
Handle the case where
document.cookie === ''and perhaps other parsing issues.Testing
I have gone over the contributing documentation.