♻️ [RUMF-1508] reorganise error handling

[bcaudan]

Motivation

Prepare handling of error without stacktrace

Changes

• add more tests
• reorganise instrumentOnError
• reorganise computeRawError

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[bcaudan]

Current dependencies on/for this PR:

• main
  • PR ♻️ [RUMF-1508] refactor error types / constants #2179
    • PR ♻️ [RUMF-1508] reorganise error handling #2181 👈
      • PR ✨[RUMF-1508] Provide stack trace for all uncaught exceptions #2182

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Merging #2181 (443f8d9) into main (9b61225) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
+ Coverage   93.81%   93.85%   +0.04%     
==========================================
  Files         201      201              
  Lines        6062     6073      +11     
  Branches     1337     1344       +7     
==========================================
+ Hits         5687     5700      +13     
+ Misses        375      373       -2     

Impacted Files	Coverage Δ
packages/core/src/domain/error/error.ts	95.16% <100.00%> (+1.28%)	⬆️
packages/core/src/domain/tracekit/tracekit.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[bcaudan]

/to-staging

[dd-devflow]

🚂 Branch Integration

commit 62e2d43 will soon be integrated into staging-17.

This build is going to start soon! (estimated merge in less than 0s)

you can cancel this operation by commenting your pull request with /to-staging -c!

[dd-devflow]

🚂 Branch Integration

commit 62e2d43 has been merged into staging-17

[BenoitZugmeyer]

❓ question: ‏I don't see this check in the original code, why do we need it now?

[bcaudan]

There are cases where stackTrace.stack = [] or stackTrace.stack = [{url: undefined, column: undefined, line: undefined}] and we want to use the NO_ERROR_STACK_PRESENT_MESSAGE for those.
In the original code, those cases happened in the first if but it will change in the following PR.

[bcaudan]

/to-staging

[dd-devflow]

🚂 Branch Integration

commit 443f8d9 will soon be integrated into staging-17.

This build is going to start soon! (estimated merge in less than 34m)

you can cancel this operation by commenting your pull request with /to-staging -c!

[dd-devflow]

🚂 Branch Integration

commit 443f8d9 has been merged into staging-17