Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 [RUMF-1470] Enable sanitize for user-provided data #2175

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

yannickadam
Copy link
Contributor

@yannickadam yannickadam commented Apr 19, 2023

Motivation

Enable sanitize in production
Do not sanitize the original error propagated in computeRawError, as it never gets serialized.

Changes

Removed SANITIZE_INPUTS feature flag
Removed sanitize on originalError in computeRawError

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@yannickadam yannickadam requested a review from a team as a code owner April 19, 2023 12:26
@yannickadam yannickadam changed the title 👷 Remove sanitize feature flag 👷 RUMF1470 - Remove sanitize feature flag Apr 19, 2023
@yannickadam yannickadam changed the title 👷 RUMF1470 - Remove sanitize feature flag 👷 RUMF-1470 - Remove sanitize feature flag Apr 19, 2023
@yannickadam yannickadam changed the title 👷 RUMF-1470 - Remove sanitize feature flag 👷 [RUMF-1470] Remove sanitize feature flag Apr 19, 2023
@yannickadam yannickadam force-pushed the yannick.adam/RUMF-1470-Remove-sanitize-feature-flag branch from b631255 to c677d1b Compare April 19, 2023 15:29
@yannickadam yannickadam force-pushed the yannick.adam/RUMF-1470-Remove-sanitize-feature-flag branch from c677d1b to 2ba74ca Compare April 19, 2023 15:49
@yannickadam yannickadam changed the title 👷 [RUMF-1470] Remove sanitize feature flag 👷 [RUMF-1470] Enable sanitize for user-provided data Apr 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #2175 (8bb5311) into main (fbcfb8a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2175      +/-   ##
==========================================
- Coverage   93.80%   93.78%   -0.03%     
==========================================
  Files         201      201              
  Lines        6086     6062      -24     
  Branches     1360     1337      -23     
==========================================
- Hits         5709     5685      -24     
  Misses        377      377              
Impacted Files Coverage Δ
packages/core/src/domain/error/error.ts 93.87% <ø> (+1.56%) ⬆️
packages/core/src/tools/experimentalFeatures.ts 100.00% <ø> (ø)
packages/logs/src/boot/logsPublicApi.ts 100.00% <ø> (+1.92%) ⬆️
...kages/core/src/domain/console/consoleObservable.ts 100.00% <100.00%> (ø)
...ges/core/src/tools/serialisation/contextManager.ts 100.00% <100.00%> (+5.40%) ⬆️
packages/logs/src/domain/logger.ts 95.74% <100.00%> (+1.74%) ⬆️
packages/rum-core/src/boot/rumPublicApi.ts 91.39% <100.00%> (+1.29%) ⬆️
packages/rum-core/src/domain/limitModification.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yannickadam yannickadam merged commit 9b61225 into main Apr 24, 2023
@yannickadam yannickadam deleted the yannick.adam/RUMF-1470-Remove-sanitize-feature-flag branch April 24, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants