Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 remove sinon dependency #2149

Merged
merged 1 commit into from
Apr 11, 2023
Merged

👷 remove sinon dependency #2149

merged 1 commit into from
Apr 11, 2023

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

As of #2144 , sinon is not used anymore.

Changes

Remove sinon from dependencies.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner April 11, 2023 11:57
@codecov-commenter
Copy link

Codecov Report

Merging #2149 (ae5a0b9) into main (7459938) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2149      +/-   ##
==========================================
- Coverage   93.77%   93.75%   -0.02%     
==========================================
  Files         198      198              
  Lines        6089     6089              
  Branches     1357     1357              
==========================================
- Hits         5710     5709       -1     
- Misses        379      380       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer merged commit 4b267ee into main Apr 11, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/remove-sinon branch April 11, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants