Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️[RUMF-1517] add test index files #2115

Merged
merged 6 commits into from
Mar 29, 2023
Merged

♻️[RUMF-1517] add test index files #2115

merged 6 commits into from
Mar 29, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 28, 2023

Motivation

Ease future splitting of spec utilities by importing directly from test directory

Changes

add files:

  • core/test/index
  • rum-core/test/index
  • rum/test/index

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link
Contributor Author

bcaudan commented Mar 28, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Copy link
Contributor Author

bcaudan commented Mar 28, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #2115 (d5b9b01) into main (74f1f60) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2115      +/-   ##
==========================================
+ Coverage   93.56%   93.73%   +0.17%     
==========================================
  Files         166      166              
  Lines        5702     5702              
  Branches     1302     1302              
==========================================
+ Hits         5335     5345      +10     
+ Misses        367      357      -10     
Impacted Files Coverage Δ
packages/rum-core/test/createFakeClick.ts 87.50% <ø> (ø)
packages/rum-core/test/testSetupBuilder.ts 94.73% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan marked this pull request as ready for review March 28, 2023 13:29
@bcaudan bcaudan requested review from a team as code owners March 28, 2023 13:29
@bcaudan bcaudan merged commit 0b18707 into main Mar 29, 2023
@bcaudan bcaudan deleted the bcaudan/add-index branch March 29, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants