♻️ [devext] move button to end the session next to the session info #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/developer-extension--move-end-session-button
branch
from
aa8b829 to
5d4c363
Compare
bcaudan
approved these changes
Mar 14, 2023
Base automatically changed from
benoit/developer-extension--move-components
to
innovation-week/developer-extension
March 17, 2023 09:54
BenoitZugmeyer
force-pushed
the
benoit/developer-extension--move-end-session-button
branch
from
5d4c363 to
0fa5f5f
Compare
BenoitZugmeyer
deleted the
benoit/developer-extension--move-end-session-button
branch
BenoitZugmeyer
added a commit
that referenced
this pull request
Mar 28, 2023
* ♻️ [devext] move components modules around (#2071) * ♻️ [devext] move button to end the session next to the session info (#2073) * 🚚 [devext] move devtools status to panel (#2074) Having the devtools status in the store was always a bit weird, since it's more a temporary state than something we want to store on the long term. Also, its refresh strategy was not very good since it was only refreshed when the store changed, so it did not refresh when running `yarn dev` without manipulating the extension settings. Let's put it in the devtools panel directly, as a hook that periodically polls the dev server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having the "end session" button in Settings is weird and impractical
Changes
Move the button next to the Session info:
Testing
I have gone over the contributing documentation.