🔊🐛 [RUMF-201] add internal logs for buggy load event measures #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bcaudan
reviewed
Dec 17, 2019
The purpose of this PR is to detect invalid values we may produce and log them along with the informations necessary to identify the associated View event.
|
bcaudan
reviewed
Dec 17, 2019
bcaudan
approved these changes
Dec 17, 2019
BenoitZugmeyer
deleted the
benoit/add-debug-monitoring-for-unexpected-measures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help debug the weird measure values shown in the View Explorer, this adds debug logs when the SDK sends abnormal load event duration (above one day). This is intentionaly at the lowest level possible (right before serialization) to make sure we have the final value transmited to the backend.