🐛[RUMF-1450] stop computing coordinates for focus/blur records #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
force-pushed
the
bcaudan/replay-remove-xy-blur-focus
branch
2 times, most recently
from
a10c314 to
cd66e28
Compare
bcaudan
force-pushed
the
bcaudan/replay-remove-xy-blur-focus
branch
from
cd66e28 to
fb543ba
Compare
Codecov Report
@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 93.31% 93.19% -0.12%
==========================================
Files 145 145
Lines 5504 5511 +7
Branches 1255 1256 +1
==========================================
Hits 5136 5136
- Misses 368 375 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
amortemousque
approved these changes
Feb 1, 2023
ThibautGeriz
approved these changes
Feb 1, 2023
BenoitZugmeyer
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On focus and blur records, we don't need coordinates and this computation trigger an unnecessary reflow which can lead to customer site behaviour difference on safari, cf issue.
Changes
Stop computing coordinates for focus and blur records.
Testing
I have gone over the contributing documentation.