-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
βπ reset input state at the beginning of each click #1968
Merged
BenoitZugmeyer
merged 2 commits into
main
from
benoit/frustration-signals--reset-input-state
Jan 25, 2023
Merged
βπ reset input state at the beginning of each click #1968
BenoitZugmeyer
merged 2 commits into
main
from
benoit/frustration-signals--reset-input-state
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was causing a lot of false negative dead clicks. Once an "input" event was triggered on the page, all subsequent clicks were considered to have changed an input, so no dead clicks were produced anymore.
Codecov Report
@@ Coverage Diff @@
## main #1968 +/- ##
=======================================
Coverage 93.33% 93.34%
=======================================
Files 144 144
Lines 5480 5482 +2
Branches 1245 1246 +1
=======================================
+ Hits 5115 5117 +2
Misses 365 365
π£ Weβre building smart automated test selection to slash your CI/CD build times. Learn more |
amortemousque
approved these changes
Jan 25, 2023
BenoitZugmeyer
deleted the
benoit/frustration-signals--reset-input-state
branch
January 25, 2023 14:08
This was referenced Jan 27, 2023
BenoitZugmeyer
changed the title
π reset input state at the beginning of each click
βπ reset input state at the beginning of each click
Jan 27, 2023
4 tasks
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
4 tasks
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 7, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 7, 2023
pm_trace_id: 13144861 feature_branch_pipeline_id: 13144861 source: to-staging * commit '6a98a9480c800aff92ce4c5d37270534623f7661': β remove now unneeded experimental flag from e2e tests β π₯ remove now unneeded clock mock in tests π©π enable fix #1979 π remove pointerup_delay info for #1958 π©π enable fix #1958 π©π enable fix #1968 π©π enable fix #1986
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 10, 2023
* π©π enable fix #1986 * π©π enable fix #1968 * π©π enable fix #1958 * π remove pointerup_delay info for #1958 * π©π enable fix #1979 * β π₯ remove now unneeded clock mock in tests * β remove now unneeded experimental flag from e2e tests * π rename `onStartEvent` to `onPointerUp` * π rename startEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket is part of an effort to improve dead clicks.
All three fixes are behind the
dead_click_fixes
and will be released together after some dogfooding.Motivation
This issue was causing a lot of false negative dead clicks. Once an "input" event was triggered on the page, all subsequent clicks were considered to have changed an input, so no dead clicks were produced anymore.
Changes
Reset the
hasInputChanged
state whenever a new click happens.Testing
I have gone over the contributing documentation.