Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βš—πŸ› reset input state at the beginning of each click #1968

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 24, 2023

This ticket is part of an effort to improve dead clicks.

All three fixes are behind the dead_click_fixes and will be released together after some dogfooding.

Motivation

This issue was causing a lot of false negative dead clicks. Once an "input" event was triggered on the page, all subsequent clicks were considered to have changed an input, so no dead clicks were produced anymore.

Changes

Reset the hasInputChanged state whenever a new click happens.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

This issue was causing a lot of false negative dead clicks. Once an
"input" event was triggered on the page, all subsequent clicks were
considered to have changed an input, so no dead clicks were produced
anymore.
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner January 24, 2023 16:50
@codecov-commenter
Copy link

Codecov Report

Merging #1968 (4a404eb) into main (bef92ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1968   +/-   ##
=======================================
  Coverage   93.33%   93.34%           
=======================================
  Files         144      144           
  Lines        5480     5482    +2     
  Branches     1245     1246    +1     
=======================================
+ Hits         5115     5117    +2     
  Misses        365      365           
Impacted Files Coverage Ξ”
...n/rumEventsCollection/action/listenActionEvents.ts 100.00% <100.00%> (ΓΈ)

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer merged commit 57d9e2a into main Jan 25, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/frustration-signals--reset-input-state branch January 25, 2023 14:08
@BenoitZugmeyer BenoitZugmeyer changed the title πŸ› reset input state at the beginning of each click βš—πŸ› reset input state at the beginning of each click Jan 27, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 6, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 6, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 7, 2023
BenoitZugmeyer added a commit that referenced this pull request Feb 7, 2023
 pm_trace_id: 13144861
 feature_branch_pipeline_id: 13144861
 source: to-staging

* commit '6a98a9480c800aff92ce4c5d37270534623f7661':
  βœ… remove now unneeded experimental flag from e2e tests
  βœ…πŸ”₯ remove now unneeded clock mock in tests
  πŸš©πŸ› enable fix #1979
  πŸ”‡ remove pointerup_delay info for #1958
  πŸš©πŸ› enable fix #1958
  πŸš©πŸ› enable fix #1968
  πŸš©πŸ› enable fix #1986
BenoitZugmeyer added a commit that referenced this pull request Feb 10, 2023
* πŸš©πŸ› enable fix #1986

* πŸš©πŸ› enable fix #1968

* πŸš©πŸ› enable fix #1958

* πŸ”‡ remove pointerup_delay info for #1958

* πŸš©πŸ› enable fix #1979

* βœ…πŸ”₯ remove now unneeded clock mock in tests

* βœ… remove now unneeded experimental flag from e2e tests

* πŸ‘Œ rename `onStartEvent` to `onPointerUp`

* πŸ‘Œ rename startEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants