Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅[karma cbt] add retry for UnhandledException #194

Merged
merged 2 commits into from
Dec 5, 2019
Merged

✅[karma cbt] add retry for UnhandledException #194

merged 2 commits into from
Dec 5, 2019

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 5, 2019

Most common fail for cbt unit tests, add 3 retries for this case.

@bcaudan bcaudan requested a review from a team as a code owner December 5, 2019 08:52
BenoitZugmeyer
BenoitZugmeyer requested changes Dec 5, 2019
View reviewed changes
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some doc, why are we doing this and from where the unhandled rejection occurs (is it from our side? karma side?).

@bcaudan
Copy link
Contributor Author

bcaudan commented Dec 5, 2019

It would be nice to have some doc, why are we doing this and from where the unhandled rejection occurs (is it from our side? karma side?).

I don't know if it is from karma or cbt, I have search for similar cases without success...
With a better understanding of the issue, I would probably have a different strategy. The idea here is to increase our tolerance to this issue and limit the number of manual retry we have to make.
What do you think?

@BenoitZugmeyer
Copy link
Member

Alright that's a good first step

@bcaudan bcaudan merged commit a32a9ec into master Dec 5, 2019
@bcaudan bcaudan deleted the bcaudan/cbt branch December 5, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcaudan @BenoitZugmeyer