Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-1397] init parameter standardisation #1917

Merged
merged 5 commits into from
Jan 6, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jan 4, 2023

Motivation

Uniformise init config parameters names across SDKs

Changes

  • Introduce sessionSampleRate and deprecate sampleRate
  • Introduce traceSampleRate and deprecate tracingSampleRate
  • Introduce trackUserInteractions and deprecate trackInteractions

Note: documentation will be updated after the release of those new parameters

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #1917 (8a82f44) into main (0e419cb) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1917      +/-   ##
==========================================
- Coverage   93.28%   93.20%   -0.09%     
==========================================
  Files         141      141              
  Lines        5347     5353       +6     
  Branches     1201     1207       +6     
==========================================
+ Hits         4988     4989       +1     
- Misses        359      364       +5     
Impacted Files Coverage Δ
packages/rum-core/src/boot/rumPublicApi.ts 93.40% <ø> (ø)
...ges/core/src/domain/configuration/configuration.ts 91.66% <100.00%> (+0.49%) ⬆️
packages/logs/src/domain/logsSessionManager.ts 100.00% <100.00%> (ø)
packages/rum-core/src/domain/configuration.ts 93.87% <100.00%> (+0.26%) ⬆️
...ain/rumEventsCollection/action/actionCollection.ts 95.45% <100.00%> (ø)
...rumEventsCollection/resource/resourceCollection.ts 100.00% <100.00%> (ø)
packages/rum-core/src/domain/rumSessionManager.ts 90.69% <100.00%> (ø)
packages/rum-core/src/domain/tracing/tracer.ts 100.00% <100.00%> (ø)
...rum-core/src/domain/contexts/foregroundContexts.ts 90.76% <0.00%> (-6.16%) ⬇️
packages/rum/src/domain/record/mutationObserver.ts 95.86% <0.00%> (-0.69%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan marked this pull request as ready for review January 5, 2023 08:51
@bcaudan bcaudan requested review from a team as code owners January 5, 2023 08:51
@bcaudan bcaudan merged commit f22e47e into main Jan 6, 2023
@bcaudan bcaudan deleted the bcaudan/new-conf branch January 6, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants