Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 [RUMF-1345] add telemetry logs on untrusted events #1910

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 2, 2023

Motivation

We want to better understand what type of untrusted events are being recorded.

Superseds #1878

Changes

Add a telemetry debug log when an untrusted event is dispatched and caught by our SDK. We limit the number of reported events to one per event type to avoid sending too many logs.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer changed the title 🔊 [RUMF-1345] untrusted events add telemetry 🔊 [RUMF-1345] add telemetry logs on untrusted events Jan 2, 2023
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review January 2, 2023 17:36
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner January 2, 2023 17:36
packages/core/src/browser/addEventListener.ts Outdated Show resolved Hide resolved
@BenoitZugmeyer BenoitZugmeyer merged commit c264097 into main Jan 3, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/untrusted-events--add-telemetry branch January 3, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants