🐛 [RUMF-1421] keep updating the view event counters after view end #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/event-counters--continue-counting-after-view-end
branch
from
b931a08 to
060a6dd
Compare
Codecov Report
@@ Coverage Diff @@
## main #1864 +/- ##
==========================================
- Coverage 93.19% 93.12% -0.08%
==========================================
Files 137 138 +1
Lines 5161 5164 +3
Branches 1150 1150
==========================================
- Hits 4810 4809 -1
- Misses 351 355 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
liywjl
reviewed
Dec 12, 2022
packages/rum-core/src/domain/rumEventsCollection/view/trackViewEventCounts.ts
Outdated
Show resolved
Hide resolved
bcaudan
approved these changes
Dec 13, 2022
|
|
||
| return { | ||
| scheduleStop: () => { | ||
| setTimeout(stop, KEEP_TRACKING_EVENT_COUNTS_AFTER_VIEW_DELAY) |
There was a problem hiding this comment.
💬 suggestion: missing monitor
Suggested change
| setTimeout(stop, KEEP_TRACKING_EVENT_COUNTS_AFTER_VIEW_DELAY) | |
| setTimeout(monitor(stop), KEEP_TRACKING_EVENT_COUNTS_AFTER_VIEW_DELAY) |
Co-authored-by: William Lacroix <[email protected]>
liywjl
approved these changes
Dec 13, 2022
BenoitZugmeyer
deleted the
benoit/event-counters--continue-counting-after-view-end
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve View child event counters accuracy
Changes
Keep updating View child event counters after the view ends.
Testing
I have gone over the contributing documentation.