✨ Move extension settings to a Settings panel #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use the new features of Mantine, let's upgrade to the latest version.
This allows the inner components to chose where to put margins. It also helps to implement a nice scroll strategy for tabs because now we can use things like `100vh`.
This component is extracted from the Infos tab and will be reused in the future Settings tab.
Settings are getting a bit dense. Let's use a separate Settings tab for it. This is a bit similar to what Chrome and Firefox devtools are doing, in the sense that settings are centralized in a full screen interface.
This commit improves the overall layout and make tabs content scroll as expected.
Codecov Report
@@ Coverage Diff @@
## main #1847 +/- ##
==========================================
- Coverage 93.11% 93.03% -0.08%
==========================================
Files 131 131
Lines 5081 5081
Branches 1138 1138
==========================================
- Hits 4731 4727 -4
- Misses 350 354 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
liywjl
approved these changes
Dec 1, 2022
|
👏 praise: Love it! |
amortemousque
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adjust the extension UI to make it nicer (tweak margins and scrolling areas) and move most settings to a Settings panel
Changes
Testing
I have gone over the contributing documentation.