⬆️ [RUMF-1434] fix yarn failing to install puppeteer on M1 mac #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, puppeteer (or the underlying CDP session) don't notify us when a request finishes. This makes the scenario stuck indefinitely. This commit improves the situation by: * listening to the `response` event (it has been observed that sometimes `requestfailed` and `requestfinished` are not notified, but `response` is) * adding a 5 seconds timeout to all requests
It seems like following the puppeteer upgrade (maybe because it uses a different Chromium version), the Chrome Devtools `Profiler` profile is reset on each page navigation. Thus, we lose some precious information. This commit fix it by stop/start the profiler more often, aggregating the different resulting profiles.
Twitter does not display the "Preferences" page controls if we don't consent to cookies anymore. This commit adds the expected cookie to opt-in to cookie consent.
4 tasks
liywjl
approved these changes
Nov 28, 2022
bcaudan
reviewed
Nov 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
+ Coverage 93.03% 93.11% +0.07%
==========================================
Files 131 131
Lines 5081 5081
Branches 1138 1138
==========================================
+ Hits 4727 4731 +4
+ Misses 354 350 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1772
Changes
Upgrade puppeteer and fix a few issues related to the performances script
Testing
I have gone over the contributing documentation.