Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUMF-1440] improve feature flag collection implementation #1839

Merged

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Nov 25, 2022

Motivation

Extracting feature flag management to a dedicated component.

Changes

  • Remove feature flag logic from trackViews
  • Create featureFlagContexts
  • Use featureFlagContexts in viewCollection and errorCollection

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested review from a team as code owners November 25, 2022 14:22
@amortemousque amortemousque force-pushed the aymeric/improve-feature-flag-collection-implementation branch from 8f8d086 to 28c7185 Compare November 25, 2022 14:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #1839 (d4e32e4) into main (329ff34) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1839      +/-   ##
==========================================
+ Coverage   93.03%   93.12%   +0.09%     
==========================================
  Files         131      132       +1     
  Lines        5081     5093      +12     
  Branches     1138     1139       +1     
==========================================
+ Hits         4727     4743      +16     
+ Misses        354      350       -4     
Impacted Files Coverage Δ
...kages/rum-core/src/domain/contexts/viewContexts.ts 100.00% <ø> (ø)
.../src/domain/rumEventsCollection/view/trackViews.ts 100.00% <ø> (ø)
packages/rum-core/src/boot/startRum.ts 86.66% <100.00%> (+0.62%) ⬆️
...rum-core/src/domain/contexts/featureFlagContext.ts 100.00% <100.00%> (ø)
...omain/rumEventsCollection/error/errorCollection.ts 100.00% <100.00%> (ø)
.../domain/rumEventsCollection/view/viewCollection.ts 100.00% <100.00%> (ø)
...rum-core/src/domain/contexts/foregroundContexts.ts 96.92% <0.00%> (+6.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque amortemousque merged commit daf478b into main Dec 7, 2022
@amortemousque amortemousque deleted the aymeric/improve-feature-flag-collection-implementation branch December 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants