-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUMF-1440] improve feature flag collection implementation #1839
Merged
amortemousque
merged 6 commits into
main
from
aymeric/improve-feature-flag-collection-implementation
Dec 7, 2022
Merged
♻️ [RUMF-1440] improve feature flag collection implementation #1839
amortemousque
merged 6 commits into
main
from
aymeric/improve-feature-flag-collection-implementation
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/improve-feature-flag-collection-implementation
branch
from
November 25, 2022 14:34
8f8d086
to
28c7185
Compare
Codecov Report
@@ Coverage Diff @@
## main #1839 +/- ##
==========================================
+ Coverage 93.03% 93.12% +0.09%
==========================================
Files 131 132 +1
Lines 5081 5093 +12
Branches 1138 1139 +1
==========================================
+ Hits 4727 4743 +16
+ Misses 354 350 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
liywjl
reviewed
Nov 25, 2022
packages/rum-core/src/domain/rumEventsCollection/error/errorCollection.ts
Show resolved
Hide resolved
bcaudan
reviewed
Nov 28, 2022
packages/rum-core/src/domain/contexts/featureFlagContext.spec.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Dec 5, 2022
bcaudan
approved these changes
Dec 5, 2022
amortemousque
deleted the
aymeric/improve-feature-flag-collection-implementation
branch
December 7, 2022 16:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Extracting feature flag management to a dedicated component.
Changes
Testing
I have gone over the contributing documentation.