✨ [RUMF-1396] migrate extension to manifest v3 #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package has been updated with various fixes to support Manifest V3
Removed some dead code that won't work anymore with Manifest V3
BenoitZugmeyer
force-pushed
the
benoit/migrate-extension-to-manifest-v3
branch
from
90aa48f to
5914555
Compare
BenoitZugmeyer
force-pushed
the
benoit/migrate-extension-to-manifest-v3
branch
from
5914555 to
308b331
Compare
Codecov Report
@@ Coverage Diff @@
## main #1828 +/- ##
==========================================
- Coverage 93.10% 93.03% -0.08%
==========================================
Files 131 131
Lines 5065 5065
Branches 1134 1134
==========================================
- Hits 4716 4712 -4
- Misses 349 353 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
With Manifest V3, connection between the devtools panel and the background service worker can be lost when the service worker is refreshed. I experienced it very often while working on the extension (every time I changed the background script). To help UX/DX, this commit adds an alert to allow refreshing easily the devtools panel.
BenoitZugmeyer
force-pushed
the
benoit/migrate-extension-to-manifest-v3
branch
from
308b331 to
61f84fa
Compare
liywjl
approved these changes
Nov 22, 2022
| @@ -1,3 +1,16 @@ | |||
| export const DEV_LOGS_URL = 'http://localhost:8080/datadog-logs.js' | |||
| export const DEV_RUM_URL = 'http://localhost:8080/datadog-rum.js' | |||
| export const DEV_RUM_SLIM_URL = 'http://localhost:8080/datadog-rum-slim.js' | |||
|
|
|||
| export const INTAKE_DOMAINS = [ | |||
| }) | ||
|
|
||
| async function refreshDevServerStatus() { | ||
| const timeoutId = setTimeout(() => setStore({ devServerStatus: 'checking' }), 500) |
There was a problem hiding this comment.
did you not want to phase out store?
There was a problem hiding this comment.
Yes I want but not in this PR :) I only moved this function in another file.
| <Suspense fallback={<></>}> | ||
| <Panel /> | ||
| </Suspense> | ||
| <Suspense fallback={<></>}>{isDisconnected ? <DisconnectAlert /> : <Panel />}</Suspense> |
amortemousque
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Get ready for manifest v2 phasing out. See https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/
Fixes #1691
Changes
Testing
I have gone over the contributing documentation.