✨ Clear event list on page reload for SDK extension #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1825 +/- ##
==========================================
- Coverage 93.11% 93.03% -0.08%
==========================================
Files 131 131
Lines 5081 5081
Branches 1138 1138
==========================================
- Hits 4731 4727 -4
- Misses 350 354 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 3 commits
November 18, 2022 15:50
amortemousque
changed the title
Comment on lines
34
to
43
| if (!preserveEvents) { | ||
| const clearCurrentEvents = (details: chrome.webNavigation.WebNavigationTransitionCallbackDetails) => { | ||
| if (details.transitionType === 'reload') setEvents([]) | ||
| } | ||
| chrome.webNavigation.onCommitted.addListener(clearCurrentEvents) | ||
| return () => { | ||
| removeListener() | ||
| chrome.webNavigation.onCommitted.removeListener(clearCurrentEvents) | ||
| } | ||
| } |
There was a problem hiding this comment.
Because of this early return, the removeListener won't always be called. What about using two useEffect like I suggested here?
BenoitZugmeyer
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clear events when we refresh page
Testing
I have gone over the contributing documentation.