Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [RUMF-1425] enable request retry/throttle for replay intake #1819

Merged
merged 1 commit into from
Nov 14, 2022
Merged

✨ [RUMF-1425] enable request retry/throttle for replay intake #1819

merged 1 commit into from
Nov 14, 2022

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Make retry/throttle strategy used by default for requests sent to the replay intake

Changes

Enable change introduced in #1807

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners November 14, 2022 10:31
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/retry--enable-retry-strategy-for-replay branch from d2db408 to 0b37814 Compare November 14, 2022 10:32
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/retry--enable-retry-strategy-for-replay branch from 0b37814 to 685545f Compare November 14, 2022 10:42
@BenoitZugmeyer BenoitZugmeyer merged commit 1728958 into main Nov 14, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/retry--enable-retry-strategy-for-replay branch November 14, 2022 14:31
BenoitZugmeyer added a commit that referenced this pull request Nov 14, 2022
@BenoitZugmeyer
Revert "✨ [RUMF-1425] enable request retry/throttle for replay intake (…
a73c15a 
…#1819)"

This reverts commit 1728958.
@BenoitZugmeyer BenoitZugmeyer mentioned this pull request Nov 14, 2022
Merged
BenoitZugmeyer added a commit that referenced this pull request Nov 14, 2022
@BenoitZugmeyer
Revert "✨ [RUMF-1425] enable request retry/throttle for replay intake (…
b4105f8 
…#1819)" (#1820)

This reverts commit 1728958.
BenoitZugmeyer added a commit that referenced this pull request Dec 14, 2022
@BenoitZugmeyer
Revert "Revert "✨ [RUMF-1425] enable request retry/throttle for repla…
cbc83ff 
…y intake (#1819)" (#1820)"

This reverts commit b4105f8.
@BenoitZugmeyer BenoitZugmeyer mentioned this pull request Dec 14, 2022
Merged
4 tasks
BenoitZugmeyer added a commit that referenced this pull request Dec 14, 2022
@BenoitZugmeyer
Merge branch 'benoit/re-enable-retry-replay' (cbc83ff) into staging-51
40919f8 
 pm_trace_id: 11831456
 feature_branch_pipeline_id: 11831456
 source: to-staging

* commit 'cbc83fff4aa26f23b27b36d8e0123db90d32ecec':
  Revert "Revert "✨ [RUMF-1425] enable request retry/throttle for replay intake (#1819)" (#1820)"
  v4.28.0 (#1876)
BenoitZugmeyer added a commit that referenced this pull request Dec 14, 2022
@BenoitZugmeyer
Revert "Revert "✨ [RUMF-1425] enable request retry/throttle for repla…
86a527d 
…y intake (#1819)" (#1820)" (#1880)

This reverts commit b4105f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liywjl liywjl liywjl approved these changes

@amortemousque amortemousque amortemousque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenoitZugmeyer @amortemousque @liywjl