Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ [RUMF-1433] Remove Preflight request Performance Entry check #1813

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

liywjl
Copy link
Contributor

@liywjl liywjl commented Nov 8, 2022

Motivation

If we match 2 performance entries on a request, we try and check if one of them is a preflight option request.

This behaviour is no longer present on modern browsers.

Changes

  • remove check
  • delete adjacent test

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@liywjl liywjl requested a review from a team as a code owner November 8, 2022 10:31
@codecov-commenter
Copy link

Codecov Report

Merging #1813 (df9c12f) into main (0ab07cb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
+ Coverage   93.23%   93.25%   +0.01%     
==========================================
  Files         131      131              
  Lines        5071     5067       -4     
  Branches     1136     1135       -1     
==========================================
- Hits         4728     4725       -3     
+ Misses        343      342       -1     
Impacted Files Coverage Δ
...rumEventsCollection/resource/matchRequestTiming.ts 94.44% <ø> (-1.02%) ⬇️
packages/core/src/tools/timeUtils.ts 100.00% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liywjl liywjl merged commit 150a7c6 into main Nov 14, 2022
@liywjl liywjl deleted the william/remove-preflight-performance-entry-check branch November 14, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants