Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Enable telemetry configuration #1780

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

amortemousque
Copy link
Collaborator

Motivation

This PR enable telemetry configuration implemented in #1760

Changes

Remove telemetry_configuration ff

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner October 20, 2022 12:38
@amortemousque amortemousque force-pushed the aymeric/enable-telemetry-collection branch from 97dc16e to 3d12ec1 Compare October 20, 2022 12:48
@amortemousque amortemousque force-pushed the aymeric/enable-telemetry-collection branch from e20166c to 9018f9d Compare October 20, 2022 13:09
@codecov-commenter
Copy link

Codecov Report

Merging #1780 (94cda68) into main (de8bab7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1780      +/-   ##
==========================================
+ Coverage   90.93%   90.95%   +0.01%     
==========================================
  Files         129      129              
  Lines        5030     5030              
  Branches     1128     1128              
==========================================
+ Hits         4574     4575       +1     
+ Misses        456      455       -1     
Impacted Files Coverage Δ
packages/core/src/domain/telemetry/telemetry.ts 96.00% <100.00%> (ø)
packages/core/src/transport/batch.ts 94.18% <0.00%> (+1.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque amortemousque merged commit 2365036 into main Oct 20, 2022
@amortemousque amortemousque deleted the aymeric/enable-telemetry-collection branch October 20, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants